openaddresses / machine

Scripts for running OpenAddresses on a complete data set and publishing the results.
http://results.openaddresses.io/
ISC License
97 stars 36 forks source link

Creating two Tippecanoe tilesets and merging them #631

Closed migurski closed 7 years ago

migurski commented 7 years ago

We added properties to the dotmap output in https://github.com/openaddresses/machine/pull/620, and then removed them again in https://github.com/openaddresses/machine/commit/b45f73a251bbb6ebdc1ccba517b717f791d49e37 when the output cracked the 500KB-per-tile limit. This change attempts to introduce properties only at the highest zoom level, 14, per advice from @ericfischer on using tile-join to combine tilesets built with different property settings.

Closes #626.

e-n-f commented 7 years ago

@migurski https://github.com/mapbox/tippecanoe/pull/411 will add the -n option to tile-join to set the tileset name.

migurski commented 7 years ago

After running overnight, the Tippecanoe process successfully generated a 7.3G tileset, but the upload to Mapbox failed after two hours:

DEBUG: GET /uploads/v1/open-addresses/credentials
DEBUG: /tmp/oa-xqtl_mxy.mbtiles --> 43/_pending/9jndc9rt6sw20060ssyb3d2jc/open-addresses
DEBUG: POST /uploads/v1/open-addresses '
{
    "url": "https://tilestream-tilesets-production.s3.amazonaws.com/43/_pending/9jndc9rt6sw20060ssyb3d2jc/open-addresses",
    "tileset": "open-addresses.lec54np1"
}
'
DEBUG: GET /uploads/v1/open-addresses/cj2d3d7xk05xx2wthb8cg82zz
(repeats for two hours)

Error message: “Processing timed out. Please read our troubleshooting guide to help optimize your upload.”

e-n-f commented 7 years ago

There is a Mapbox-internal ticket about what the proper timeout should be for mbtiles upload and how it should relate to the tileset size and the number of tiles that it contains. I'll link to this ticket there.

migurski commented 7 years ago

Testing this again, with the new four-quadrant approach.

migurski commented 7 years ago

Ongoing display work for this issue seems to be triggering some oddness in Mapbox GL; issue filed at https://github.com/mapbox/mapbox-gl-js/issues/4699 to learn more.

migurski commented 7 years ago

It worked! Took 33hrs. There will be ways to shorten this, but it’ll do for now in support of a data-filled dotmap.

e-n-f commented 7 years ago

Has tile-join been working for you? I just became aware of the problem fixed in https://github.com/mapbox/tippecanoe/pull/416, which had been causing uploads of tile-joined tilesets to fail. Older versions of tile-join would have been OK though.

migurski commented 7 years ago

It’s been good so far!