openaddresses / openaddresses

A global repository of open address, building, and parcel data.
http://openaddresses.io/
BSD 3-Clause "New" or "Revised" License
2.84k stars 852 forks source link

au/countrywide using wrong postcode field #2164

Closed andrewharvey closed 7 years ago

andrewharvey commented 7 years ago

au/countrywide is using the gnaf-loader locality_postcode field as the address postcode: https://github.com/openaddresses/openaddresses/blob/master/scripts/au/gnaf.sh#L63

locality_postcode is the postcode of the locality for this address, not the postcode for this address point. https://github.com/minus34/gnaf-loader/blob/dfc2a2e22420e70ebd2e52c8a9aa112b11bd9f32/postgres-scripts/03-12-reference-populate-addresses-2.sql#L41

I think OA should be using the 'postcode' field.

/cc @minus34 in case you have any guidance here?

minus34 commented 7 years ago

Due to the unofficial method used by the PSMA, the address level postcodes are usually worse than the locality_postcode values. The aggregation method used to generate locality_postcode values knocks out a good number of the postcode outliers.

FYI - the PSMA aren't actually allowed to use the postcodes in the Postal Address File in GNAF even though its a key GNAF data source; due to Australia Post licensing limitations. This may change in the future as there are ongoing (multi-year) discussions.

andrewharvey commented 7 years ago

@minus34 Thanks for the explanation.