openai-php / client

⚡️ OpenAI PHP is a supercharged community-maintained PHP API client that allows you to interact with OpenAI API.
MIT License
4.7k stars 483 forks source link

Main #175

Open maina-david opened 1 year ago

maina-david commented 1 year ago

update Psr18Client in client

gehrisandro commented 1 year ago

@maina-david Could you please provide some background information why this change is needed?

maina-david commented 1 year ago

@gehrisandro HttpDiscovery is not an HTTP client itself but rather a library that helps one discover available PSR-18 client implementations in the environment. It allows the package to be more flexible and not tied to a specific HTTP client implementation like Symfony HttpClient.

gehrisandro commented 1 year ago

Thank you for clarification. This sounds like a reasonable decision.

Will check if everything is compatible with the other packages and then going to merge it.