search

openai-php / client

⚡️ OpenAI PHP is a supercharged community-maintained PHP API client that allows you to interact with OpenAI API.
MIT License
4.57k stars 466 forks source link

Add default system_fingerprint to completion create response fixture #310

Closed elliotmassen closed 5 months ago

elliotmassen commented 6 months ago

What:

Description:

This PR continues from #308 by also adding the system_fingerprint field to the Completions fixture and CreateResponse class. This allows the field to be set via the CreateResponse.fake method, which has been included in the "fake with override" Completion's test.

Related:

gehrisandro commented 6 months ago

Hi @elliotmassen

Thank you for your PR, but it looks like this field is not included in a completion response.

I know, the OpenAI docs says, that it should be included, but I was not able to see this field in a test request and I don't think OpenAI has actually added it, as the completion API is already deprecated.

Have you an evidence, that there actually is a system_fingerprint field in the response?

gehrisandro commented 5 months ago

Closed due to inactivity. Feel free to open a new PR.