Introduce OpenAIThrowable - Githubissues

openai-php / client

⚡️ OpenAI PHP is a supercharged community-maintained PHP API client that allows you to interact with OpenAI API.

MIT License

5k stars 521 forks source link

Introduce OpenAIThrowable #429

Open VincentLanglet opened 5 months ago

VincentLanglet commented 5 months ago

What:

[ ] Bug Fix
[x] New Feature

Description:

Hi @gehrisandro

I'm trying to move https://github.com/openai-php/client/pull/287 forward by splitting it in 3 smaller PRs:

First PR to introduce OpenAIThrowable
Second PR to introduce UnreadableResponse exception
Third PR with only Phpdoc update

The purpose of this PR is to provide an easy way to try/catch method of this lib:

It avoids catching \Exception which catch everything
It avoids catching OpenAI\Exceptions\ErrorException|OpenAI\Exceptions\InvalidArgumentException|... which is complicated and can miss an exception if a new one is introduced later.

Related:

https://github.com/openai-php/client/pull/287

VincentLanglet commented 3 months ago

Friendly ping @nunomaduro @gehrisandro,

Is something missing for a review ? Since https://github.com/openai-php/client/pull/287 got interest but no reaction, I'm trying to moving it forward with smaller PR. Please tell me if I can do it better :)

Thanks

bytestream commented 2 months ago

I agree that this is a useful and beneficial improvement. I see no reason why this cannot be merged @nunomaduro

VincentLanglet commented 1 month ago

Anyway to move forward this PR @gehrisandro @nunomaduro ?

Thanks a lot