openai / atari-py

A packaged and slightly-modified version of https://github.com/bbitmaster/ale_python_interface
GNU General Public License v2.0
367 stars 183 forks source link

install fails on mac #44

Closed christopherhesse closed 5 years ago

christopherhesse commented 5 years ago
pip install -e .
Installing collected packages: atari-py
  Found existing installation: atari-py 0.1.1
    Uninstalling atari-py-0.1.1:
      Successfully uninstalled atari-py-0.1.1
  Running setup.py develop for atari-py
    Complete output from command /Users/csh/miniconda3/bin/python -c "import setuptools, tokenize;__file__='/Users/csh/agi/atari-py/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" develop --no-deps:
    running develop
    running egg_info
    writing atari_py.egg-info/PKG-INFO
    writing dependency_links to atari_py.egg-info/dependency_links.txt
    writing requirements to atari_py.egg-info/requires.txt
    writing top-level names to atari_py.egg-info/top_level.txt
    reading manifest file 'atari_py.egg-info/SOURCES.txt'
    writing manifest file 'atari_py.egg-info/SOURCES.txt'
    running build_ext
    Unable to execute 'make build -C atari_py/ale_interface -j 7'. HINT: are you sure `make` is installed?
    error: [Errno 2] No such file or directory: 'build/lib.macosx-10.7-x86_64-3.6': 'build/lib.macosx-10.7-x86_64-3.6'

    ----------------------------------------
  Rolling back uninstall of atari-py

It works if I remove the cwd parameter from https://github.com/openai/atari-py/blob/master/setup.py#L16

endrift commented 5 years ago

This looks like the same issue as #43

christopherhesse commented 5 years ago

Should be fixed now