Building requires zlib1g-dev, not just zlib1g

openai / atari-py

A packaged and slightly-modified version of https://github.com/bbitmaster/ale_python_interface

GNU General Public License v2.0

373 stars 183 forks source link

Building requires zlib1g-dev, not just zlib1g #66

Closed jkterry1 closed 5 years ago

jkterry1 commented 5 years ago

This isn't stated in the readme, and without the dev version installed you get the following incredibly opaque build error:

/home/justinkterry/Documents/atari-py/atari_py/ale_interface/src/common/ScreenExporter.cpp:18:10: fatal error: zlib.h: No such file or directory
 #include <zlib.h>
          ^~~~~~~~
compilation terminated.

You should at least update the readme file to reflect this, and ideally include a check with a useful error message during building

christopherhesse commented 5 years ago

Added that to the readme. This is just normal dev stuff though, the precompiled binaries are there to prevent users from having to deal with this stuff in general. Thanks for filing the issue!