search

openai / atari-py

A packaged and slightly-modified version of https://github.com/bbitmaster/ale_python_interface
GNU General Public License v2.0
374 stars 185 forks source link

Unable to load ROMs with ale.loadROM() #89

Open Gregliest opened 3 years ago

Gregliest commented 3 years ago

I followed the directions in the readme for downloading, unrarring/unzipping, and loading the rom files. I can see them in .local/lib/python3.8/site-packages/atari_py/atari_roms.

However, ale.loadROM() is unable to find the ROM file:

>>> import atari_py
>>> ale = atari_py.ALEInterface()
>>> ale.loadROM("pong.bin")
ROM file pong.bin not found.

My C++ is a bit rusty, but looks like this might be wanting a full path? https://github.com/openai/atari-py/blob/master/atari_py/ale_interface/src/ale_interface.cpp#L124

I wasn't able to get the solution for the gym to work for just the base library.

Gregliest commented 3 years ago

Figure this out. The roms have to be in a folder called roms, not atari_roms. Seems like a bug with the import script.

Gregliest commented 3 years ago

https://github.com/openai/atari-py/blob/master/atari_py/games.py#L8 should be roms instead of atari_roms for this case, but not sure where else this is used. (Also the exception should change with it, https://github.com/openai/atari-py/blob/master/atari_py/games.py#L10)