Open DanielTakeshi opened 7 years ago
Hey @DanielTakeshi did you ever resolve this? I tried reviving the deprecated wrapper ([https://github.com/openai/baselines/commit/bb403781182c6e31d3bf5de16f42b0cb0d8421f7#diff-0c67b0657be4a64c70d569f9dac118fa]) but ran into shape issues. Thanks!
@melodyguan I am simply training agents with the newer wrapper. I'm halving the number of iterations though as I don't have that much computation power.
It seems that we cannot simply replace "wrap_dqn" by "wrap_deepmind" since the env returned are different.
See the old wrap "wrap_dqn" here: https://github.com/yenchenlin/rl-attack-detection/blob/master/baselines/common/atari_wrappers_deprecated.py
There may be more parts to edit in those Atari codes to fit the new wrapper. Still trying
@LiYingTW -Any luck with the new wrapper and Atari. A new pull request for Rainbow paper was submitted today and it uses the old wrapper
Hey all, any updates? Best practices to mitigate deprecated wrapper?
Hi,
I've been using some of the excellent pre-trained models from DQN and its variants. However, looking at more recent algorithms (PPO, A2C, TRPO, etc.) it seems like we're now using a different Atari wrapper,
wrap_deepmind
instead of the deprecatedwrap_dqn
. I inspected the frames and the newer wrapper keeps the game scores in the images, while the older one had them cropped out of the pixels.The
deepq/experiments
directory still seems to be using the deprecated wrapper. Just to be clear,Thanks.
Edit: follow up point, I noticed here that you're telling us to copy over LazyFrames when using the updated wrapper. However, LazyFrames appears to be deprecated. Is there anything I need to do with LazyFrames to get Atari working on the newer wrapper?