search

openai / coinrun

Code for the paper "Quantifying Transfer in Reinforcement Learning"
https://blog.openai.com/quantifying-generalization-in-reinforcement-learning/
MIT License
388 stars 87 forks source link

Build on High Sierra #3

Closed kvfrans closed 5 years ago

kvfrans commented 5 years ago

Hi,

I was trying to build the environment and kept running into this error: `coinrun.cpp:10:10: fatal error: 'QtCore/QMutexLocker' file not found

include <QtCore/QMutexLocker>

     ^~~~~~~~~~~~~~~~~~~~~

1 error generated. make: *** [.build-release/coinrun.o] Error 1 coinrun: make failed`

The solution (with help from here) is to 

brew install pkg-config

and then 

export PKG_CONFIG_PATH=/usr/local/opt/qt5/lib:/usr/local/opt/qt5/lib/QtWidgets.framework:/usr/local/opt/qt5/lib/pkgconfig

Afterwards the environment compiles successfully, on my system at least.

christopherhesse commented 5 years ago

The PKG_CONFIG_PATH should be set to export PKG_CONFIG_PATH=/usr/local/opt/qt5/lib/pkgconfig by default, are those other paths both necessary on your system?

christopherhesse commented 5 years ago

@kvfrans ^

christopherhesse commented 5 years ago

We added pkg-config to the mac dependencies, I'll close this assuming there's nothing else to adjust.