openai / deeptype

Code for the paper "DeepType: Multilingual Entity Linking by Neural Type System Evolution"
https://arxiv.org/abs/1802.01021
Other
648 stars 145 forks source link

Property 'FACET_OF' missing in wikidata properties #10

Closed karimvision closed 6 years ago

karimvision commented 6 years ago

First of all, awesome work 👏 and thank you so much for sharing your knowledge, really appreciate it 😃

it seems that the property FACET_OF is missing from the wikidata properties here, this caused the error below while running _python3 extraction/fast_link_fixer.py ${DATA_DIR}wikidata ${DATA_DIR}${LANGUAGE}_trie ${DATA_DIR}${LANGUAGE}_triefixed

inside extraction/full_preprocess.sh, as a quick fix i just commented it out (this line) and it works fine after that

load 'P31' ('instance of')
inverting relation 'P31' ('instance of')
load inverted 'P31' ('instance of')
load 'P279' ('subclass of')
inverting relation 'P279' ('subclass of')
load inverted 'P279' ('subclass of')
load 'P360' ('is a list of')
inverting relation 'P360' ('is a list of')
load inverted 'P360' ('is a list of')
load 'P361' ('part of')
inverting relation 'P361' ('part of')
load inverted 'P361' ('part of')
Traceback (most recent call last):
  File "extraction/fast_link_fixer.py", line 594, in <module>
    main()
  File "extraction/fast_link_fixer.py", line 469, in main
    num_category_link=8
  File "extraction/fast_link_fixer.py", line 273, in fix
    {"steps": [wprop.INSTANCE_OF, wprop.FACET_OF]},
AttributeError: module 'wikidata_linker_utils.wikidata_properties' has no attribute 'FACET_OF'
galtay commented 6 years ago

probably resolved by #9

karimvision commented 6 years ago

oh, it was a typo then, got it, thanks!, closing this issue now

galtay commented 6 years ago

updated fix to #12