search

openai / glow

Code for reproducing results in "Glow: Generative Flow with Invertible 1x1 Convolutions"
https://arxiv.org/abs/1807.03039
MIT License
3.11k stars 516 forks source link

Typo in the source code #45

Closed chenzhekl closed 5 years ago

chenzhekl commented 6 years ago

It seems

if arg_scope([get_variable_ddi], trainable=trainable):

should be

with arg_scope([get_variable_ddi], trainable=trainable):

https://github.com/openai/glow/blob/654ddd0ddd976526824455074aa1eaaa92d095d8/tfops.py#L72

dpkingma commented 6 years ago

@chenzhekl That's indeed a typo. It doesn't affect the experiments; we never use trainable=False, and it's True by default.