openai / gym-http-api

API to access OpenAI Gym from other languages via HTTP
MIT License
293 stars 142 forks source link

Python client upload() bug #32

Closed unixpickle closed 7 years ago

unixpickle commented 7 years ago

For the /v1/upload API, the request must have a training_dir key. However, the python client erroneously uses a key called directory instead:

data = {'directory': directory,
        'force': force,
        'resume': resume,
        'video_callable': video_callable}
self._post_request(route, data)

The upload() method was probably just never tested before.

Fixing this might save someone a bit of debugging time if they use the Python client as a guide for their own client.

unixpickle commented 7 years ago

My bad, I was looking at monitor_start in the client.