search

openai / lm-human-preferences

Code for the paper Fine-Tuning Language Models from Human Preferences
https://openai.com/blog/fine-tuning-gpt-2/
MIT License
1.24k stars 164 forks source link

replace gs:// prefixes w/ MS URIs #23

Closed leondz closed 1 year ago

leondz commented 1 year ago

as indicated in readme - also, readme indication now removed

WuTheFWasThat commented 1 year ago

thanks!

but... are you sure this is everything? there's another reference in the README, at a minimum. I think it's best to either keep the original warning or to be 100% sure everything is covered (hopefully git grep 'gs://' should turn up nothing!)

kinda sad if this was the only change required haha, sorry I never bothered to test

WuTheFWasThat commented 1 year ago

there's also a bunch of functions in lm_human_preferences/utils/gcs.py, not sure if places they're used broke?

leondz commented 1 year ago

my oh my. such hardcoding! ;) give it a few minutes + i'll update

WuTheFWasThat commented 1 year ago

i mean, you should feel free to not fix everything, so long as you keep the original notice :)

WuTheFWasThat commented 1 year ago

yeah... can't find the books stuff. probably should just delete.

i do see az://openaipublic/lm-human-preferences/datasets/shortstories/shortstories_v0_{split}.jsonl but not sure that's the same

leondz commented 1 year ago

i mean, you should feel free to not fix everything, so long as you keep the original notice :)

yeah, that's valid, restored!