search

openai / neural-mmo

Code for the paper "Neural MMO: A Massively Multiagent Game Environment for Training and Evaluating Intelligent Agents"
https://openai.com/blog/neural-mmo/
MIT License
1.57k stars 262 forks source link

fix render agent pos bug #22

Closed wwxFromTju closed 4 years ago

wwxFromTju commented 5 years ago

fix render agent pos bug.

more detail see: https://github.com/openai/neural-mmo/issues/5#issue-417233063

jsuarez5341 commented 5 years ago

Thanks for the pull req! I actually spent about an hour trying to reproduce the issue -- I'd be somewhat surprised if it's really just a straight off by one error on the overall position. I'll need to set aside a bit of time to test to make sure this fix doesn't result in desync anywhere else -- will likely merge it on Monday.

jsuarez5341 commented 5 years ago

Funny -- I could not reproduce the issue earlier, but this patch causes exactly the issue that was described. You've confirmed that this actually fixes the issue on your setup?

wwxFromTju commented 5 years ago

I tested the code in Ubuntu and macos, and then used Chrome to render, all of which have the above problems.

Are you using the code for this repository? It seems that you have cleaned up the code and placed it on github, which may be a bug in the github version.

kumarict commented 5 years ago

This fix worked for me.

jsuarez5341 commented 4 years ago

No longer relevant with no client. Closing