search

openai / openai-dotnet

The official .NET library for the OpenAI API
https://www.nuget.org/packages/OpenAI/AbsoluteLatest
MIT License
722 stars 62 forks source link

refactor: Moved InternalsVisibleTo to .csproj. #19

Closed HavenDV closed 3 weeks ago

weshaggard commented 3 weeks ago

@HavenDV is there an advantage to doing this in the csproj over the cs file? IIRC the csproj just generates a file on your behalf which to me doesn't really add any value and in fact causes more temp files to be created.

HavenDV commented 3 weeks ago

No big difference, except that we will get rid of this file and all project settings will be stored in one place I see the benefit in that lately you almost never expect an AssemblyInfo file to be present in a project, because now it is almost always generated, and it is better to put it in the project file. I don't think generation has even a small impact on build time, besides it is generated for other attributes anyway

Feel free to just decline this, it's just a suggestion

Ste1io commented 3 weeks ago

+1 for this PR, as it is the more modern approach.

weshaggard commented 3 weeks ago

Thanks for the contribution and I buy the argument that this file is getting generated for other attributes already so there isn't any real reason to not add this one. I made one suggestion which makes separates the public key into its own property.