License issue - Githubissues

StefanTerdell commented 1 month ago

Confirm this is a Node library issue and not an underlying OpenAI API issue

[X] This is an issue with the Node library

Describe the bug

Hi OpenAI! 👋🏻 It's really cool to see you're making good use of my package zod-to-json-schema! I see you've made some interesting changes in the vendored version. I'd be happy to take a look at them in the form of a PR and integrate them into the "canonical" version, which you can then use as a regular dependency.

In the meantime, to resolve the issue caused by the license, you can include the license and copyright notice in the vendored files

...or offer me a job 😉

To Reproduce

See ISC license conditions in https://github.com/StefanTerdell/zod-to-json-schema/blob/master/LICENSE

Code snippets

No response

OS

n/a

Node version

n/a

Library version

4.55.4

RobertCraigie commented 1 month ago

Hey @StefanTerdell, really sorry we messed up the licensing here!

you can include the license and copyright notice in the vendored files

Will add the LICENSE file 👍

To be clear, would you like us to add your license copy to the top of every vendored file? e.g.

/**
  ISC License

  Copyright (c) 2020, Stefan Terdell

  Permission to use, copy, modify, and/or distribute this software for any
  purpose with or without fee is hereby granted, provided that the above
  copyright notice and this permission notice appear in all copies.

  THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
  WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
  MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
  ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
  WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
  ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
  OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
**/

const zodToJsonSchema = <Target extends Targets = 'jsonSchema7'>(
// ...