search

openai / pixel-cnn

Code for the paper "PixelCNN++: A PixelCNN Implementation with Discretized Logistic Mixture Likelihood and Other Modifications"
https://arxiv.org/abs/1701.05517
Other
1.91k stars 437 forks source link

Moving to Tensorflow 1.0 API. #12

Closed prichemond closed 7 years ago

prichemond commented 7 years ago

Also auto-formatting the code.

trinkerin commented 7 years ago

Hi folks, I submitted pull request #11 with these exact changes (and a doc update) 4 days before this pull request got created. This pull request was unnecessary and I find it really off-putting that this is the one that got merged. Poor form.

prichemond commented 7 years ago

I apologize Liam ; it might be my fault as I sent an email to the authors a week + before explaining what I was doing and that I wanted to incorporate changes ; ended up being distracted enough by real life that it took me around 10 days before sending the PR. It would hence look like our PRs crossed, and my relative non-familiarity with Github is at the root of the situation. I do however hope you understand no harm was meant, and that we are all sharing a similar goal in improving the software and contributing in a healthy way. I'll make sure to follow up my email with a PR sooner next time, and do believe your contributions will be valued as they rightly deserve.

Best regards

Pierre Harvey Richemond On Tue, 14 Mar 2017 at 21:52, liamocn notifications@github.com wrote:

Hi folks, I submitted pull request #11 https://github.com/openai/pixel-cnn/pull/11 with these exact changes (and a doc update) 4 days before this pull request got created. This pull request was unnecessary and I find it really off-putting that this is the one that got merged. Poor form.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openai/pixel-cnn/pull/12#issuecomment-286572741, or mute the thread https://github.com/notifications/unsubscribe-auth/AVs7LjBu3yTGrY-1ZKm9DYJDLqNW_-fhks5rlww1gaJpZM4MY6Nk .