openai / requests-for-research

A living collection of deep learning problems
https://openai.com/requests-for-research
1.69k stars 609 forks source link

Results and code for cartpole #15

Closed kvfrans closed 8 years ago

kvfrans commented 8 years ago

Writeup and code implementing random search, hill climbing, and policy gradient on the cartpole environment

ilyasu123 commented 8 years ago

Nice work. Few comments:

is hard to connect to the previous code.  In particular, it's not obvious that you differentiate eligibility, at least not form a shallow reading.   The second point is more important, and makes it possible to change the name of the first eligibility.   Basically, don't shy away form a bit of code duplication in the explanation to your solution.   Otherwise, it's good.

Let me know when it's done and I'll merge it.
kvfrans commented 8 years ago

Thanks for the feedback, I updated the post.