openai / tiktoken

tiktoken is a fast BPE tokeniser for use with OpenAI's models.
MIT License
11.61k stars 785 forks source link

Please commit your Cargo.lock file in the repository #179

Open charles-dyfis-net opened 1 year ago

charles-dyfis-net commented 1 year ago

Not having a Cargo.lock file makes tiktoken harder to use by projects being packaged for deployment with Nix (which runs builds in a sandbox that only has network access when the hash of the content being downloaded is known ahead-of-time), and exposes users to unexpectedly having different dependency resolutions than a release was tested with upstream.

MostAwesomeDude commented 1 year ago

I intend to fix this in poetry2nix, which means that I get to choose the versions of dependencies. If you want to control which crates are used in Nix or other reproducible environments, then (at minimum) you need to add the lockfile to your releases.

VRehnberg commented 4 months ago

I second this. Not having having a Cargo.lock makes it hard to use with EasyBuild

VRehnberg commented 4 months ago

These are the latest recommendations from the Rust community afaik: