add __version__ attribute - Githubissues

openai / tiktoken

tiktoken is a fast BPE tokeniser for use with OpenAI's models.

MIT License

12.52k stars 856 forks source link

add version attribute #191

Closed rasbt closed 1 year ago

rasbt commented 1 year ago

Adds a __version__, attribute, for instance:

In [1]: import tiktoken

In [2]: tiktoken.__version__
Out[2]: '0.5.0'

Tested it locally and it works on my machine.

Fixes #190

hauntsaninja commented 1 year ago

Thanks for the PR and the suggestion, but I have a couple nits:

importlib.metadata.version is a little slow. About 20ms for me, which adds up quickly if enough many packages do it at import time. I mentioned it in the issue because if you know you need it, it's a small cost to pay, and it's probably a much stronger indication of environment than a __version__ attribute.
We'd need to re-export the symbol for type checkers to type check it correctly
tiktoken has never supported Python 3.7

So better to just hardcode it, which I could do for a future release :-)