openai / universe-starter-agent

A starter agent that can solve a number of universe environments.
MIT License
1.1k stars 318 forks source link

Should step_size be tf.shape(self.x)[1:2] in model.py ? #113

Closed maplehan2009 closed 6 years ago

maplehan2009 commented 7 years ago

In the file model.py, in the init of class LSTMPolicy, step_size is defined as tf.shape(self.x)[:1] which means it is the batch size 1 in our case. However, we can see, in the following usage of tf.rnn.dynamic_rnn(), step_size has the meaning of the length of each input sequence. Since we have only one batch so step_size should be tf.shape(self.x)[1:2], am I right?

Thanks.