openai / weak-to-strong

MIT License
2.48k stars 300 forks source link

avoid adding bf16 custom kwargs unless specified by the user #18

Closed agokrani closed 8 months ago

WuTheFWasThat commented 8 months ago

(linking to https://github.com/openai/weak-to-strong/issues/11)

agokrani commented 8 months ago

Hi @WuTheFWasThat, Not really sure if the above comment is for me to change something or is it just a comment about the functionality? Should we merge this or use other solution proposed by Shrivastava?

WuTheFWasThat commented 8 months ago

yes i think that approach is better!