Feature/replace location field

lingxkong commented 1 year ago

Description of the change

Replace "region" and "country" fields with "city", "region", "country". Updated the team creation form to a functional state, and updated references throughout.

Type of change

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

(not sure what to put here?)

[ ] Remove location from Project in types.ts
[ ] Add country and region as strings in types.ts
[ ] Remove location input in TeamForm.vue
[ ] Add input fields for country and region in TeamForm.vue
[ ] Add country and region to firestore_converters.ts
[ ] Update Team schema in Wiki
[ ] Migrate Team.location references to Team.country and Team.region

Code review

[x] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer

couchoud commented 1 year ago

Hey @lingxkong - Just the one note. Don't worry about that checklist bit - I'm going to remove that from the template.

couchoud commented 1 year ago

@lingxkong - Sorry, but I just realized that components/project/ProjectList.vue also has a reference to the team.location property. Can you update that component as well. Thank you!

openair-collective / Carbon-Forming