search

openairplay / airplay2-receiver

AirPlay 2 Receiver - Python implementation
2.13k stars 133 forks source link

Set interface IP #31

Closed systemcrash closed 3 years ago

systemcrash commented 3 years ago

New PR which corresponds to the older, closed #6

systemcrash commented 3 years ago

I think this PR is ready. Testers welcome.

TheSpookyCat commented 3 years ago 
Traceback (most recent call last):
  File "E:\Projects\Web Dev\airplay2-receiver-flags\ap2-receiver.py", line 740, in <module>
    if ifen[ni.AF_INET6]:
KeyError: 23

This on my device which doesn't support IPv6. Roughly the same error as if you try to run the current master branch from a device which doesn't support IPv6.

TheSpookyCat commented 3 years ago

One second, I'll open a PR to this branch on your fork to fix it.

systemcrash commented 3 years ago

I just re-based my master to match this master to align PRs here better.

TheSpookyCat commented 3 years ago

After the aforementioned issue is fixed this branch works as expected. Yet to test a "restart scenario" as I'm not quite sure how I can force one; open to suggestions.

TheSpookyCat commented 3 years ago

@systemcrash Excuse this being off-topc and the wrong place for this but is there anything setup for this repo that is better suited for lengthy and casual discussions about this repo and how it works?

systemcrash commented 3 years ago

Best is just to open an issue with a topic you want to discuss. If you understand git and open source, you understand how this repo works 😎