Important changes in intercepted PAR

[Emblanc]

The PAR intercepted by each plant is measured for each day in the model. For some plants there are very important changes in the intercepted PAR between one day and the next day

[christian34]

Can you post the input parameters that produce that bug, together with the output to look at to see it ?

[pradal]

The best solution would be to write another test that reproduce the problem:

[Emblanc]

To my knowledge, this problem occurs in any simulation. When we look at the PAR_per_axes.csv file, we can see values such as 10^6 µmol of PAR/m^2 for some plants on a specific day

[pradal]

The bug is in the scene management in Walter. Caribu computes correctly the light (dixit @Emblanc ) but Walter change in some way this information.

[christian34]

I write a test in PR #34 that seems to reproduce the bug : using the test base simulation, I can observe 100% variation in Sum_PAR on one axe between two days.

[christian34]

Okay the bug (and the strange PAR) value comes form bad light sources definition (negative energy light sources). This may be due to the use of old and probably deprecated GenSky tool. I will add a test on it.

My suggestion will however to switch to astk.sun_and_sky module and re-test if the bug is still there (I will add some lines in PR #34 )

[christian34]

I fix the sky generation bug (wrong indexing of GenSky outputs) in PR #34 . The test still has day to day variation of light, but in a range that seems similar to day to day variation of PAR. Further check would need to add Current_PAR in output file. To me the bug is fixed: @Emblanc : is it okay for you ?

[christian34]

I just figured out that scene unit are in cm, whilst scen_unit are set to m in caribu call: I open a new issue/PR for that: #37 #38

[pradal]

@Emblanc @christian34 Can we close this issue?

[christian34]

Yes for me it's okay !

[Emblanc]

Yes, we can close this issue.