search

openalea / WALTer

WALTer is a 3D FSPM Wheat model
Other
4 stars 8 forks source link

Modify test_light_interception #40

Closed Emblanc closed 6 years ago

Emblanc commented 6 years ago

The test for shifts in light interception should be corrected for day to day variation of the input PAR

Emblanc commented 6 years ago

It is my understanding that the test for shifts in light interception is only conducted for the main stem of the plant n°1. Is that correct @christian34 ? If that is indeed the case, I think the test should be modified. When the bug is present (i.e. when there are important changes in the intercepted PAR between one day and the next day), it does not affect all the plants and all tillers. If the test is only made on 1 axe of 1 plant, the bug can be present without being detected.

christian34 commented 6 years ago

I add test for all axes in #38

Emblanc commented 6 years ago

The test is only conducted on a few days (which probably makes it a lot faster). Unfortunately it also means that the bug can be present without being detected. I think the test should be conducted on the whole simulation (nbj = 325 instead of 165).

Emblanc commented 6 years ago

I think it would be good to refine the test to check for maximum variation instead of mean variation, because when the bug is present, important shifts only occur on a few days.

christian34 commented 6 years ago

done in #38