search

openalea / WALTer

WALTer is a 3D FSPM Wheat model
Other
4 stars 8 forks source link

WIP: Id issue7 #46

Closed pradal closed 6 years ago

pradal commented 6 years ago

Close Issue #7

@bilalderouich

christian34 commented 6 years ago

I just push my commits for the finalisation of the externalisation of id management. @pradal @Emblanc : For me its is now ok for merging / review. Be careful: I move the walter_command code in a new module: as a result, python setup.py develop should be run again before testing.

pradal commented 6 years ago

@christian34 I will rename watercommand to main.py or command.py Because the module is walter, there is no need to prefix the module by walter

Emblanc commented 6 years ago

It is working great ! Seems like it is going to be very easy to match the simulations and their outputs now. I only changed the separator of the combi_param.csv file to tabulation. To me, this PR is ready to be merged.

pradal commented 6 years ago

Thanks Emmanuelle and Christian. Great work.