openalea / WALTer

WALTer is a 3D FSPM Wheat model
Other
4 stars 8 forks source link

ID_simul management #7

Closed Emblanc closed 6 years ago

Emblanc commented 6 years ago

WALTer.lpy generates an ID for each simulation and writes it in a file in the simulation directory The ID should be generated by the launcher

pradal commented 6 years ago

Add a column with the ID for latter analysis

pradal commented 6 years ago

Analysis:

To implement the new strategy:

Emblanc commented 6 years ago

generate the same file named from_json_to_humanbeing.txt (but stored in columns) :+1:

This is exactly what we need to be able to analyse the outputs of our simulations : we used to have such a file (but it was generated by a bash script) and all our analysis scripts are based on it. Ideally, the new file should be a csv file with tabulation separator. The file should be the same one as the sim_scheme.csv used to launch the simulation(s) but with an extra column named ID. We could call it combi_param.csv.

pradal commented 6 years ago

Nice. This is what we have done. Do you need ID_simul.txt file? The problem is that if we run several simulation in parallel, this file is written by several processes.

Another solution may be to pass the ID as parameter, or to run each simulation in its own repository with inputs and outputs. Something like: hufdjkghkjhgd/ input/ output/

Then we do not care about unique ID but we can manage the simulation number after the simulation.

christian34 commented 6 years ago

A small update from today's Bilal activity: the combi_param.csv has been generated and ID is being passed to walter.lpy via params (he will probably comit tomorrow)

Still, from within python, this require several manual steps (that are chained in main.py):

To automatise things a bit further, the first 3 steps could be done at project instanciation, and then run will run all (default) or some (identified by number) simulation. This could work if 1 project =1 directory = 1 csv parameter file = xx simulations (one per line of the csv) can we consider we are always in this the case (or does the csv file attached to one dir evolve with time ?)?

pradal commented 6 years ago

Have you seen my branch where I implement all of this? This is the issue #46 (only some part of what you present).

christian34 commented 6 years ago

Yes this is the branch he worked on

Emblanc commented 6 years ago

Nice. This is what we have done.

Perfect !

Do you need ID_simul.txt file?

I do not need this file. It used to be written just to pass the information of the id from WALTer.lpy to our bash script.

Another solution may be to pass the ID as parameter, or to run each simulation in its own repository with inputs and outputs. Something like: hufdjkghkjhgd/ input/ output/

It is better for me if it stays the way it is now with : my_project_containing_several_simulations/ ..output/ ....nbovefbvef/ #outputs for simulatoin1 ....laqoscdnso/ #outputs for simulation2 ....

To automatise things a bit further, the first 3 steps could be done at project instanciation, and then run will run all (default) or some (identified by number) simulation. This could work if 1 project =1 directory = 1 csv parameter file = xx simulations (one per line of the csv) can we consider we are always in this the case (or does the csv file attached to one dir evolve with time ?)?

We can consider we are always in this case : each time I need to run a set of simulations, I open a new project.

pradal commented 6 years ago

Excellent. So we are quite close to the result. We mainly just have to investigate why we have some times errors.

christian34 commented 6 years ago

Closed by #46