search

openalea / WALTer

WALTer is a 3D FSPM Wheat model
Other
4 stars 8 forks source link

Debug crop scheme #86

Closed christian34 closed 5 years ago

christian34 commented 5 years ago

Externalise and test crop_sheme functions

christian34 commented 5 years ago

Ok the global test passes on the branch !

Emblanc commented 5 years ago

I checked the expected results for test_crop_mesh_for_nplants and I agree with them

Emblanc commented 5 years ago

The simulations we run for tests are no longer the right ones. I will change the sim_schemes.csv accordingly

Emblanc commented 5 years ago

The centre/border plants are no longer well defined. For example, when running the sim_scheme_test_combi_params_err.csv, there should be 182 plants, including 58 that are centre plants. Instead, all 182 plants are considered to be in the centre of the plot.

christian34 commented 5 years ago

Okay, thanks for the report ! I will include a test for securing the control of the repartition of border / center plants !

christian34 commented 5 years ago

Oups I forgot to pass border distance to the central domain function (resulting in all plants considered as center plants) : things should be better now... I will still write a test !

Emblanc commented 5 years ago

Thank you, it seems to be working fine now !