openalias / dnscrypt-python

DNSCrypt Python Library
7 stars 2 forks source link

A few comments #1

Open jedisct1 opened 9 years ago

jedisct1 commented 9 years ago

Thanks for this pure Python implementation!

A few comments:

bdabkowski commented 9 years ago

Thank you for your input. I updated the library to handle multiple certificates and changed magic query to be extracted from certificates. The hardcoded value came from here: https://github.com/Cofyc/dnscrypt-wrapper - apparently all of the resolvers on the list use it, so I didn't noticed it may vary.

As for your last point, I'm not sure what is needed to be implemented here. Should I be checking for the TC flag in the response, and querying again?