openalm / Extension-UtilitiesPack

Release Management utility tasks
Other
34 stars 38 forks source link

Adding Support for non-environment configuration #17

Closed jmichaud-ips closed 7 years ago

jmichaud-ips commented 8 years ago

Updated to support non-environment configurations. This allows for a config file to replace settings with variable tokens, then those tokens to get replaced with TFS values. This allows for config files to contain actual values instead of doing a transform during a build to inject tokens into the config. And the token injection points would be the same for all environments.

jmichaud-ips commented 8 years ago

Any thoughts on this functionality? Removing the Environment requirement basically makes this like a config transform. There are only a couple advantages over config transforms, one, they don't happen out of the box with visual studio. Two, I can't do a sub-string replace, but the tokenize script can with a minor update. I could do a new pull request for non-environment config plus find and replace, but keep out my logging changes.

harshil93 commented 8 years ago

Thanks @jmichaud-ips for the pull request. I was busy with my daily work. I will look into the request asap.

harshil93 commented 8 years ago

The changes looks fine to me. Can you resolve the conflicts so that I can go ahead with the merge.

harshil93 commented 7 years ago

Already have this feature contributed.

jmichaud-ips commented 7 years ago

Wow, I suck. I just now noticed you requested I resolve conflicts over a year ago. Thanks for the update.