search

openalm / Extension-UtilitiesPack

Release Management utility tasks
Other
34 stars 38 forks source link

Tokenizer does not handle encrypted environment variables #25

Closed pviktor closed 8 years ago

pviktor commented 8 years ago

I've fixed problem with encrypted environment variables.

pascalberger commented 8 years ago

Fixes #21

pascalberger commented 8 years ago

@pviktor I saw that you also added some logging statements. I've already added a PR for improved logging (#18). Also putting the token evaluation out of the for loop is also done in #22. Maybe its easier to get #18 and #22 first merged and then improve logging etc from there and have this PR only fix the encrypted variable issue with using Get-TaskVariable.

pviktor commented 8 years ago

@pascalberger I agree with you. I going to create a new pull request when you merge #18

pviktor commented 8 years ago

I've updated my pull request

pviktor commented 8 years ago

@pascalberger Are you going to merge my pull request?

pascalberger commented 8 years ago

@pviktor I cannot merge. You need to ask @anangaur

pascalberger commented 8 years ago

@harshil93 Any chance to have this also merged (if merge conflicts are solved)?

harshil93 commented 8 years ago

@pviktor Can you go use the latest vsts-task-lib. It is what we should use going forward. It may require us to use the new powershell handler.

harshil93 commented 8 years ago

Hi @pviktor, we are making change to the vsts-sdk after which directly reading the encrypted variables may not be possible in the way in which you have accessed it. I will open an issue as a feature request and will work on that in near future once the sdk changes are finalized.

Closing the issue for now.

harshil93 commented 8 years ago

A bug issue is already there. I am treating this as a bug rather than a feature. You can subscribe to that. We are working on the best way to provide access to encrypted variables so that won’t be the case.

Regards, Harshil Lodhi

From: Ivan Zlatev [mailto:notifications@github.com] Sent: Tuesday, April 26, 2016 8:18 PM To: openalm/Extension-UtilitiesPack Extension-UtilitiesPack@noreply.github.com Cc: Harshil Lodhi harslo@microsoft.com; State change state_change@noreply.github.com Subject: Re: [openalm/Extension-UtilitiesPack] Tokenizer does not handle encrypted environment variables (#25)

Does that mean we won't be able to tokenize encrypted values in the near-term feature? Can you please link the new feature here - I am can't find it so I can subscribe to it?

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHubhttps://github.com/openalm/Extension-UtilitiesPack/pull/25#issuecomment-214769717