openalm / Extension-UtilitiesPack

Release Management utility tasks
Other
34 stars 38 forks source link

Update documentation to mention how to specify which Environment to use for the Tokenizer task #89

Closed deadlydog closed 6 years ago

deadlydog commented 6 years ago

The Tokenizer task documentation mentions that the json file can have multiple <release environment name> sections in it. How then do I specify which environment section should be used to do the token replacement at deploy-time? Does the name of the section in the json file need to match the $(Release.EnvironmentName) VSTS variable value? Or something else? This seems like a pretty crucial piece of info that's missing from the documentation, or maybe it's there and I'm just missing it? Thanks!

deadlydog commented 6 years ago

After some testing I see that the environment you specify in the json file must match the name of the Environment in VSTS Release Management. I would ask that the documentation get updated to mention that.

deadlydog commented 6 years ago

I've submitted pull request #90 to address this issue.

deadlydog commented 6 years ago

Any word on getting pull request #90 accepted? Make sure you do the "rich diff" in GitHub so it's easy to see what changes I actually made; the default "source diff" just shows the whole file as being changed, instead of just the words/lines that I changed.

deadlydog commented 6 years ago

crickets chirping

deadlydog commented 6 years ago

@harshil93 any change of getting this PR #90 merged in?

deadlydog commented 6 years ago

Awesome, thanks for merging the PR in @harshil93 👍