search

openalto / alto-experimental

Some epxerimental projects for the following ALTO release.
Eclipse Public License 1.0
1 stars 1 forks source link

Require tests of bandwidth monitoring #8

Open fno2010 opened 7 years ago

fno2010 commented 7 years ago

We do not test basic bandwidth monitoring function in either unit tests or integration tests. From my basic code review, it does not work in some special cases. For example, how can this line make sure the initial monitoring work?

We need somebody to check it and make sure it works.

fno2010 commented 6 years ago

I think this line is incorrect and conducts the divide-zero exception. Because getSecond will always return 0. And I believe it also conducts issue #10.

fno2010 commented 6 years ago

The quick fix cannot work because many node-connectors cannot update their duration properties (not sure it's the hardware issue or ODL issue):

"openflow:75096032357597:3401"
{
  "second": 0,
  "nanosecond": 0
}
"openflow:75096032357597:6201"
{
  "second": 0,
  "nanosecond": 0
}
"openflow:137432795454528:111"
{
  "second": 819660,
  "nanosecond": 527000000
}
"openflow:137432795454528:89"
{
  "second": 808576,
  "nanosecond": 769000000
}
"openflow:365545302427456:137"
{
  "second": 0,
  "nanosecond": 0
}
"openflow:365545302427456:225"
{
  "second": 0,
  "nanosecond": 0
}

A trade-off may be taking the timestamp in controller side (system time).