search

openambitproject / openambit

openambit
280 stars 82 forks source link

Promote the GUI Movescount support to a separate library #83

Closed paddy-hack closed 9 years ago

paddy-hack commented 9 years ago

Talking to Suunto's Movescount isn't just the prerogative of the openambit GUI. There's more applications that might want to do so. To that end, it would be beneficial to move src/openambit/movescount/ to src/libmovescount/.

This would not really change much for the current code base but opens the way for other applications (eh, yes, I'm tinkering with the beginnings of a command-line utility, like @jbtheou who has also started on a GNOME extension).

paddy-hack commented 9 years ago

I have noticed the fork by @superdupersvard that does pretty much the same.

My changes work for all build scenarios (using ./build.sh or in-tree and out-of-tree cmake). The only thing that "broke" are the two translations in logstore.cpp, both of which are only used in rather exceptional situations. I am leaving these string as is for the moment. If this is a problem, it can be filed as a separate issue.