openanalytics / containerproxy

Manage HTTP proxy routes into Docker containers
Apache License 2.0
45 stars 66 forks source link

Set proxy client's max queue size #39

Closed johan13 closed 4 years ago

johan13 commented 4 years ago

The default value for LoadBalancingProxyClient's max queue length is 0. As soon as the target is busy serving a request we will return a 503 rather that waiting for a target to become available.

This causes openanalytics/shinyproxy#65.

This MR changes the max queue length from 0 to 100.

johan13 commented 4 years ago

This PR is targeted to master. Let me know if I should rebase / retarget to develop instead.

LEDfan commented 4 years ago

Hi @johan13

Thank you for you contribution! We can reproduce the problem and also observe that increasing the queue improves the availability of the proxy.

I cherry-picked your changes into this commit https://github.com/openanalytics/containerproxy/commit/2e30c3f1d2e7b6a68a3b9bc51896250d1fa85ea9 . The change is included in the just ShinyProxy 2.4.0