search

openanalytics / shinyproxy-config-examples

Configuration examples for ShinyProxy
https://www.shinyproxy.io
147 stars 110 forks source link

the proxy src should include the hostURL #10

Closed shrektan closed 3 months ago

shrektan commented 5 years ago

Moreover, I think it should be mentioned in the documentation that CORS policy will block the proxy launch by default, if the web's host is not the same as shinyproxy...

innesbre commented 4 years ago

Hi @shrektan, how do you get around that CORS policy? I can't get this demo code to work (even with your fix) and it seems the authors have abandoned it, given the lack of responses to other questions about this in here and on the openanalytics support website.

shrektan commented 4 years ago

@innesbre Sorry, it has been some time and I can't recall it.

I now use docker-compose to host the shinyproxy in production and it looks fine.

innesbre commented 3 years ago

@innesbre Sorry, it has been some time and I can't recall it.

I now use docker-compose to host the shinyproxy in production and it looks fine.

Thanks, I'm going to take a gander at your demo repo employing that method.

LEDfan commented 3 months ago

Hi

Thank you for opening this PR! The example mentioned in this PR was removed, because there are now better ways to embed a ShinyProxy app, see: https://github.com/openanalytics/shinyproxy-config-examples/tree/master/08-embedded-app

Therefore, I'm going to close this PR, but many thanks for the effort!