Allow graceful shutdown in Kubernetes config

openanalytics / shinyproxy-config-examples

Configuration examples for ShinyProxy

https://www.shinyproxy.io

147 stars 110 forks source link

Allow graceful shutdown in Kubernetes config #19

Closed fmannhardt closed 3 years ago

fmannhardt commented 4 years ago

Allow graceful shutdown by delaying the SIGTERM to the sidecar container by some time, for example, 5s. This solves the issue here: https://github.com/openanalytics/shinyproxy/issues/169

LEDfan commented 3 years ago

Hi @fmannhardt

With recent versions of ShinyProxy (I'm not sure which version exactly, but at least ShinyProxy 2.3.1) there is no need to use a kube-proxy sidecar. ShinyProxy automatically detects the location and authentication of the Kubernetes API. Therefore I removed the sidecar from the documentation and there is no need for this PR anymore. Nevertheless, thank you for your contribution and investigation!