openanalytics / shinyproxy-config-examples

Configuration examples for ShinyProxy
https://www.shinyproxy.io
149 stars 109 forks source link

Simplify example for `02-containerized-docker-engine` #42

Open ALanguillaume opened 4 months ago

ALanguillaume commented 4 months ago

Hoi @openanalytics !

Thanks for this great tool.

I was skimming through the documentation for 02-containerized-docker-engine and I am wondering if the example could be simplified or not.

I tend to use directly your openanalytics/shinyproxy image and mount the application.yml as a volume in the docker run or compose command as such:

docker run \
-v /var/run/docker.sock:/var/run/docker.sock:ro \
-v ./application.yml:/opt/shinyproxy/application.yml \
--group-add $(getent group docker | cut -d: -f3) \
--net sp-example-net \
-p 8080:8080 \
openanalytics/shinyproxy:3.1.0

Any reason not to implement this as the example ?

Is it only for didactic reasons or am I missing nothing ?

LEDfan commented 3 months ago

Hi, thanks for opening this issue. There is no specific reason for this, but I guess the original idea was to demonstrate how people could customize the image. Since mounting the config file reduces the number of steps, I'll update the example to use this approach.

ALanguillaume commented 3 months ago

Happy days ! Thanks for your reply