search

openanalytics / shinyproxy-operator

Easily run ShinyProxy on a Kubernetes cluster
https://shinyproxy.io
Apache License 2.0
36 stars 9 forks source link

Yaml separator fix #11

Closed massaox closed 3 years ago

massaox commented 3 years ago

Hi there. I was working on a demo of the shinyproxy operator for a client and noticed a minor type in one of the yaml files docs/deployment/clustered/shinyproxy2.yaml.

Looks like the separator was added in the wrong place:

...
roleRef:
  kind: Role
  name: shinyproxy-apps-role
  apiGroup: rbac.authorization.k8s.io
apiVersion: openanalytics.eu/v1alpha1
---
kind: ShinyProxy
metadata:
  name: example-shinyproxy
  namespace: yanamespace
...

The apiVersion for the Shinyproxy ended up in the roleBinding object. It should be:

...
roleRef:
  kind: Role
  name: shinyproxy-apps-role
  apiGroup: rbac.authorization.k8s.io
---
apiVersion: openanalytics.eu/v1alpha1
kind: ShinyProxy
metadata:
  name: example-shinyproxy
  namespace: yanamespace
...

Seems like this operator has potential, however I was not able to get it working yet. Seems like the shinyproxy Pod couldn't create the app Pods, but I digress....

LEDfan commented 3 years ago

Thanks the heads-up, I just fixed it!

Regarding you other problem: usually ShinyProxy gives some error when it cannot start an app. If the error is too generic, you can have a look at the events of the pod (e.g. using kubectl describe -n shinyproxy pod/... or something like https://k8slens.dev/ )

EDIT: best to watch the events during the startup of the pod, since ShinyProxy deletes the pod if it fails to start...

If you can't figure it out, feel free to open an issue!