search

openanalytics / shinyproxy-operator

Easily run ShinyProxy on a Kubernetes cluster
https://shinyproxy.io
Apache License 2.0
36 stars 9 forks source link

Support K8s v1.22 #32

Closed dev-rowbot closed 2 years ago

dev-rowbot commented 2 years ago

As per Issue #30 - the current version does not support Kubernetes V1.22 due to the removal of the v1beta1 Ingress API.

I have upgraded the Fabric8 library to version 5.8.0. I am happy to upgrade further, this was just the first version to support k8s v1.22 and I did not want to complicate my life fixing unrelated issues :-)

I have tested this against my k8s cluster (AWS EKS v1.22) and all the tests are passing. I have also deployed the operator and can confirm the examples are all working.

The gitlab actions tests will probably fail though because they run against older versions of k8s and the updates will not support some versions.

LEDfan commented 2 years ago

Hi

Many thanks for opening this PR. At first sight it looks quite good and complete. I'll go through it and test it in depth in the coming weeks.

The gitlab actions tests will probably fail though because they run against older versions of k8s and the updates will not support some versions.

Indeed, this should not be a problem, we will release a new version of the operator that will no longer support the older k8s versions (for which you can still use older versions of the operator).

LEDfan commented 2 years ago

I'm now merging this, thanks again :)

dev-rowbot commented 2 years ago

Thank you! I'm just a bit confused as to where this MR went, I see the changes are not in master?

LEDfan commented 2 years ago

Hi I should have merged the PR with develop instead of master, I didn't check this before clicking the merge button. Nevertheless, your commits are now part of this repo. I just released version 1.1.0: https://github.com/openanalytics/shinyproxy-operator/releases/tag/v1.1.0