search

openanalytics / shinyproxy-operator

Easily run ShinyProxy on a Kubernetes cluster
https://shinyproxy.io
Apache License 2.0
37 stars 9 forks source link

Add kubernetesServicePatches to shinyproxy definition #40

Closed bsauvajon closed 7 months ago

bsauvajon commented 1 year ago

Needed to add annotations to the service created by shinyproxy operator, so I copied the logic of IngressPatch to be able to patch the service definition

LEDfan commented 1 year ago

Hi, thanks for the PR. Code looks good at first sight, we will add some integration tests and mere this.

marianobilli commented 11 months ago

@LEDfan any idea/plan when this could be merged and released ?

LEDfan commented 11 months ago

Hi @marianobilli I'll definitely include this in the next release, but currently we don't have an ETA for this.

LEDfan commented 5 months ago

Hi, this is now part of the ShinyProxy Operator 2.1.0 we released today. Thanks again for your contribution!