search

openanalytics / shinyproxy-operator

Easily run ShinyProxy on a Kubernetes cluster
https://shinyproxy.io
Apache License 2.0
36 stars 9 forks source link

Feature Request: Allow service of type "NodePort" #42

Closed marianobilli closed 8 months ago

marianobilli commented 9 months ago

Dears in the service factory it is hardcoded the type "ClusterIp" for the service, in my current setup I want to point an ALB directly to the created Shiny server, and for that I need a service of type "NodePort".

Would you consider this as a feature for future releases ?

https://github.com/openanalytics/shinyproxy-operator/blob/5a0740bb9db51a2e0419a44d41311908832a6f56/src/main/kotlin/eu/openanalytics/shinyproxyoperator/components/ServiceFactory.kt#L56

marianobilli commented 8 months ago

Another alternative would be to provide a KubernetesServicePatches, like for podtemplates and ingress

marianobilli commented 8 months ago

I just realised there is an open PR for this Pull Request 40