Don't pass kwargs everywhere, but do keep params to Elasticsearch.search separated

openannotation / annotator-store

A backend store for the Annotator

http://annotateit.org/

MIT License

177 stars 66 forks source link

Don't pass kwargs everywhere, but do keep params to Elasticsearch.search separated #102

Closed Treora closed 10 years ago

Treora commented 10 years ago

A combination of #91 and #101. As suggested in https://github.com/openannotation/annotator-store/pull/101#issuecomment-57284831

nickstenning commented 10 years ago

Just a couple of nitpicks -- also I'd prefer if you could make this a clean set of changes on top of current HEAD. There's no need for a revert commit.

nickstenning commented 10 years ago

LGTM. Merging.

tilgovi commented 10 years ago

:beers: