openannotation / annotator-store

A backend store for the Annotator
http://annotateit.org/
MIT License
177 stars 66 forks source link

Do not filter out links without a type #117

Closed gergely-ujvari closed 9 years ago

gergely-ujvari commented 9 years ago

This is a quick fix for an error I've introduced which can result in searches for uri not bringing back annotations.

Error description

Therefore if the if we search for an uri of the page and that page doesn't contain a link to itself with a type (common thing among webpages) then the search for that uri will bring back nothing because the document metadata does not contain that uri, and that is not our intention.

Fix #116

Treora commented 9 years ago

I suppose we should then also remove the and 'type' in l in merge_links. Otherwise we return to the inconsistency I pointed at earlier, and the same error will occur but only later, when a document is merged into another.

gergely-ujvari commented 9 years ago

Thanks @Treora you're right.

gergely-ujvari commented 9 years ago

Okay removed it from merge_links too.

Treora commented 9 years ago

LGTM.