openapi-contrib / json-schema-to-openapi-schema

Due to the OpenAPI v3.0 and JSON Schema discrepancy, you can use this JS library to convert JSON Schema objects to OpenAPI Schema.
https://www.npmjs.com/package/@openapi-contrib/json-schema-to-openapi-schema
MIT License
111 stars 16 forks source link

[Major Refactor] Native typescript support, circular references fix, vitest #29

Closed jonluca closed 2 years ago

jonluca commented 2 years ago

This diff:

Fixes

philsturgeon commented 2 years ago

Hey @jonluca, thank you so much for this, it's looking great.

When you say "Brings in the cloudflare/json-schema-tools because that library seems to have become abandonware" what do you mean?

I see "@cloudflare/json-schema-walker": "^0.1.1", is removed from package.json, but "json-schema-walker": "^0.0.4", is added and I cannot find that on npmjs.org.

philsturgeon commented 2 years ago

I see https://github.com/jonluca/json-schema-walker/ over here but how is that ending up in NPM.

jonluca commented 2 years ago

Thanks!

Yeah let me change the name and version.

and I cannot find that on npmjs.org.

Is https://www.npmjs.com/package/json-schema-walker not visible? I didn't think it was private - I'm using it in this package and it seems to be working

how is that ending up in NPM.

I manually published it

philsturgeon commented 2 years ago

Amazing, thank you. If you ever have a bit of time in your hands, the sister package could do with Similar love as the testing and JavaScript is all super old school.

https://github.com/openapi-contrib/openapi-schema-to-json-schema

Understandable if not, I’ll have a go sometime but I’m spending the next few weeks watering saplings so our freshly planted woodlands don’t die and that means less time for code.

jonluca commented 2 years ago

Cool, sure https://github.com/openapi-contrib/openapi-schema-to-json-schema/pull/45

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: