openapi-contrib / openapi3-generator

Use your API OpenAPI 3 definition to generate code, documentation, and literally anything you need.
Apache License 2.0
90 stars 27 forks source link

fix(generator): escape special chars for path replacements with regex #33

Closed richardklose closed 4 years ago

richardklose commented 5 years ago

If a projects path contains special characters, they will be intrepeted as regular expresion instructions, which results in wrong output paths in the end. To avoid this, special characters that can be used in regular expressions should be escaped.

Fixes #32

fmvilas commented 5 years ago

Hey Richard! I'm not maintaining this project anymore. I love it but I don't have time. You're probably the person who did the most here aside from me so I'm happy to lend it to you if you're in the mood to maintain it.

Related: https://twitter.com/fmvilas/status/1167504577228353537

richardklose commented 5 years ago

Oh, that's sad to hear! You did a great job with this project so far. I personally don't have the time to maintain this project alone, but I could do so within my work at Auerswald. So If this is an option for you, we can maintain it as a company. We are already using openapi3-generator in some of our products and plan to use it in more, so as long as we continue work on our products for the next years, we will keep an eye on this.

richardklose commented 4 years ago

@philsturgeon as it looks that you are the new maintainer now, I'd like to ask, if this can be merged and released or if there is anything that should be added, before this can be merged?

philsturgeon commented 4 years ago

@richardklose im the host currently but not actively maintaining it. Would you be up to that challenge?

fmvilas commented 4 years ago

@richardklose I think you should be the one man! 🙌