search

openapi-library / OpenAPIValidators

Use Jest or Chai to assert that HTTP responses satisfy an OpenAPI spec
MIT License
189 stars 35 forks source link

fix: Array in path bug #252

Closed amitkeinan9 closed 2 years ago

amitkeinan9 commented 2 years ago

solves issue #250

Removed all commas from from path before testing with path-parser. This helps to support arrays in the path in style: simple and explode: false format

amitkeinan9 commented 2 years ago

@all-contributors please add amitkeinan9 for code

allcontributors[bot] commented 2 years ago

@amitkeinan9

I've put up a pull request to add @amitkeinan9! :tada:

codecov[bot] commented 2 years ago

Codecov Report

Merging #252 (836b3d0) into master (17271f9) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #252   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          421       423    +2     
  Branches        60        60           
=========================================
+ Hits           421       423    +2
Impacted Files Coverage Δ
...ckages/openapi-validator/lib/utils/common.utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17271f9...836b3d0. Read the comment docs.

rwalle61 commented 2 years ago

Thanks for showing how this works! I've added you as a contributor and am replacing this PR with https://github.com/openapi-library/OpenAPIValidators/pull/255, as I wanted to integrate the new tests better with our existing tests, but couldn't add commits to your forked branch. I've added you as a co-author, hope that's alright

rwalle61 commented 2 years ago

Superceded by https://github.com/openapi-library/OpenAPIValidators/pull/255