openapi-library / OpenAPIValidators

Use Jest or Chai to assert that HTTP responses satisfy an OpenAPI spec

MIT License

189 stars 35 forks source link

Bump openapi validators to v11 #281

Closed alexandermendes closed 2 years ago

alexandermendes commented 2 years ago

Version 11 of these validators contains various fixes that it would be nice to have, including this, which I just encountered. Means that a totally valid parameter like this currently fails jest-openapi validation:

{
  "in": "query",
  "name": "limit",
  "required": false,
  "schema": {
    "exclusiveMinimum": true,
    "minimum": 0,
    "type": "number"
  }
},

codecov[bot] commented 2 years ago

Codecov Report

Merging #281 (4936a49) into master (9511b66) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #281   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          418       418           
  Branches        63        65    +2     
=========================================
  Hits           418       418

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9511b66...4936a49. Read the comment docs.

alexandermendes commented 2 years ago

Guess not then 😉

rwalle61 commented 2 years ago

Sorry, have been really busy starting a new job. Thanks for raising this, will merge the improvement when I have a chance

alexandermendes commented 2 years ago

Ah no worries, thanks!

On Sat, 25 Jun 2022, 02:43 Richard Waller, @.***> wrote:

Sorry, have been really busy starting a new job. Thanks for raising this, will merge the improvement when I have a chance

— Reply to this email directly, view it on GitHub https://github.com/openapi-library/OpenAPIValidators/pull/281#issuecomment-1166167222, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLABMJCDCZ5HKXIOOOY5ODVQZP2VANCNFSM5WB2P34A . You are receiving this because you modified the open/close state.Message ID: @.***>